Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job for compatibility testing #1225

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Add CI job for compatibility testing #1225

merged 7 commits into from
Aug 4, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

Changes proposed in this PR:

  • Add job for compatibility testing to core CI workflow

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Jul 20, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (0d253d3) 76.84% compared to head (6688318) 76.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   76.84%   76.84%   -0.01%     
==========================================
  Files         390      390              
  Lines       61924    61924              
  Branches    11400    11400              
==========================================
- Hits        47586    47583       -3     
- Misses      11871    11875       +4     
+ Partials     2467     2466       -1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl
Copy link
Contributor Author

@andrewlee94 I think we now have only "good" failures, i.e. meaningful compatibility errors, as opposed to failures due to missing data files.

@andrewlee94
Copy link
Member

@lbianchi-lbl Yes, those look like real failures now. I suspect a number of them are due to changes @eslickj made to the Helmholtz EoS packages, whilst a few are due to a known issue about changes I made to the metadata.

@andrewlee94 andrewlee94 mentioned this pull request Aug 3, 2023
Merged
@lbianchi-lbl
Copy link
Contributor Author

@andrewlee94 FYI, these are the tests that are still failing after switching to IDAES/idaes-compatibility#9:

image

@andrewlee94 andrewlee94 mentioned this pull request Aug 3, 2023
Merged
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review August 3, 2023 23:29
@lbianchi-lbl lbianchi-lbl added backward-compat Affects backward compatibility CI:run-integration triggers_workflow: Integration labels Aug 3, 2023
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Aug 4, 2023
@lbianchi-lbl
Copy link
Contributor Author

Compatibility tests have been added to the required PR checks:
image

@lbianchi-lbl lbianchi-lbl merged commit 3880c2c into IDAES:main Aug 4, 2023
46 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

@eslickj eslickj Awaiting requested review from eslickj

@andrewlee94 andrewlee94 Awaiting requested review from andrewlee94

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
backward-compat Affects backward compatibility Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbianchi-lbl @andrewlee94 @idaes-build